search

iXsystems / cinder

Other
35 stars 18 forks source link

#13 #16 add apikey and https auth support #29

Closed YiHuangDB closed 1 year ago

YiHuangDB commented 1 year ago

13 root credentials must be used enhancement

16 driver wants to use http, not https and cannot handle 307s

Fix and enhancements:

  1. Adding both apikey authentication support and add https support for both basic user/password and apikey authentication.
  2. Add ixsystems_apikey and ixsystems_transport_type to README.md for documentation purpose.
  3. Remove unused code set_style, not used anywhere even in previous version.

Tested with TrueNAS 12/22 with Openstack devstack Zed release and auto test script with cinderlib.

I put some further detailed information in the code review comments FYI.

william-gr commented 1 year ago

Thanks!