search

iZettle / Presentation

Presentation is an iOS Swift library for working with UI presentations in a more structured way
MIT License
72 stars 11 forks source link

Adds SwiftLint to Presentation #22

Closed iZNunev closed 5 years ago

iZNunev commented 6 years ago

This PR introduces SwiftLint to Presentation and also fixes few warnings

nataliq commented 6 years ago

There are few linter violations left. I think Examples should also be part of the included files.

iZNunev commented 6 years ago

@nataliq it seems SwiftLint installed on travis is quite old and gives weak delegate warning for some reason, but when looking at the code the delegate IS weak, and on my local device I don't get this warning 🤔

iZNunev commented 5 years ago

@nataliq could you review this now? I removed the Examples from SwiftLint as they give random errors for files that are not even there and also for violations that are not really violations, must be old SwiftLint bug