search

iZettle / Presentation

Presentation is an iOS Swift library for working with UI presentations in a more structured way
MIT License
72 stars 11 forks source link

Add willShowViewControllerSignal #35

Closed sampettersson closed 5 years ago

sampettersson commented 5 years ago

This PR adds a signal that signals just before showing a view controller on a UINavigationController.

mansbernhardt commented 5 years ago

@Iamsamwhoami Could you add an entry to the changelog as well?

mansbernhardt commented 5 years ago

@nataliq I can see the test testNavigationBarVisibilityPreference fails for this PR. I can't see how the addition in this PR could affect any tests. I think #29 was closed for similar reasons. It would be unfortunate if these tests blocks new features coming in if they are false positives as it will discourage people to contribute. It would be great if you could investigate this further.

nataliq commented 5 years ago

agreed, i opened https://github.com/iZettle/Presentation/pull/37 I think https://github.com/iZettle/Presentation/pull/29 was closed for a different reason where the test actually found a bug.

sampettersson commented 5 years ago

@mansbernhardt #29 was definitely failing because of a real issue, was super hard to track down tough and I couldn't spend more time on it right now.

@nataliq thanks for disabling the test!

I've added a changelog entry now, so are we ready to get this merged?

mansbernhardt commented 5 years ago

@Iamsamwhoami Do you have merge privileges or should I merge this PR for you?

sampettersson commented 5 years ago

@mansbernhardt merged now 💃