iZettle / Presentation

Presentation is an iOS Swift library for working with UI presentations in a more structured way
MIT License
73 stars 11 forks source link

Fix double dismiss item setup #75

Closed nataliq-pp closed 3 years ago

nataliq-pp commented 3 years ago

modalPresentationDismissalSetup is a public function that can be used in various ways. Since 1.13.3, if the viewController passed is not a navigation controller and has a dismiss button configuration, it can get a double dismiss item if later it's presented in a navigation stack. This patch addresses the introduced issue by using the presented view controller's dismiss button configuration only if the one for viewController is missing. It also improves the API docs.