search

iZettle / sdk-ios

Add card payments from Zettle to your own app
https://developer.zettle.com/docs/ios-sdk
Other
83 stars 38 forks source link

Support for Dark Mode #287

Closed beninabox closed 4 years ago

beninabox commented 4 years ago

Expected Behavior

Upon going to 'Connect card reader', the screen should have either Dark Mode supported (therefore UI is adjusted to suit dark mode) or light mode should be forced.

Current Behavior

Upon going to 'Connect card reader', the cells which display the card reader type have a dark background whereas the rest of the screen does not. Similarly, the 'iZettle Reader 2' screen has a dark background when the rest of the flow is not designed accordingly.

Steps to Reproduce

Ensure the user is on iOS 13, launch the settings screen with dark mode turned on Tap 'Connect card reader', observe.

Context

Dark mode must be on.

Failure Logs

See screenshots IMG_0596 IMG_0595

ssikira commented 4 years ago

Hello @beninabox, we'll try to fix this issue soon by enforcing the light mode, thanks for reporting it!

beninabox commented 4 years ago

@said-iz That would be great, thanks for addressing :)

beninabox commented 4 years ago

@said-iz Any progress? It's been three months since I reported this.

ssikira commented 4 years ago

Hey @beninabox! The fix for this issue will be rolled out in our SDK 3.0 release that's coming out in the first week of July.

beninabox commented 4 years ago

Super! Very excited :)

ssikira commented 4 years ago

Fixed in SDK 3.0 :)