search

ia0 / data-encoding

Efficient and customizable data-encoding functions in Rust
https://data-encoding.rs/
MIT License
177 stars 23 forks source link

Fix no_std #41

Closed koushiro closed 3 years ago

koushiro commented 3 years ago

Signed-off-by: koushiro koushiro.cqx@gmail.com

@ia0 Please release a patch version after merging this PR

ia0 commented 3 years ago

Hi @koushiro,

Thanks for the PR! However, I think this is not needed. Did you try to update your .cargo/config.toml as described here? Also, note that this should not be needed anymore with recent rustc versions, although I did not have time to try yet.

koushiro commented 3 years ago

see https://github.com/multiformats/rust-multibase/pull/39/checks?check_run_id=1722464743 for details

koushiro commented 3 years ago

you could run the command cargo build --target thumbv6m-none-eabi under the path data-encoding/lib/macro

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.8%) to 94.274% when pulling 3cfa5f7506c2dfa7a4ee532aeede9ffdc3645110 on koushiro:fix-no-std into 7fefb4a53530e220655e2617a08833497c9ddabe on ia0:master.

ia0 commented 3 years ago

Thanks for the link, I've added a comment there. I'm closing the issue here.

See also https://github.com/ia0/data-encoding/pull/35 for previous discussions regarding multiformats/rust-multibase.