search

iaarchiver / MinimalScrollbar

Minimal but Useful Scrollbar for Google Chrome
MIT License
51 stars 9 forks source link

Fixed deprecated body.scroll #12

Closed keombre closed 6 years ago

keombre commented 7 years ago

document.body.scrollTop and document.body.scrollLeft are deprecated and have been now partially removed from Chrome. They always return 0. (StacksOverflow - ScrollTop deprecated)

document.documentElement.scrollTop contains the correct value.

Closes #11

srid99 commented 7 years ago

Thanks @keombre. Fix works! Would be nice if @iaarchiver merge this PR and publish the extension.

Meanwhile for others, attaching the MinimalScrollbar.zip of the PR which you can install manually.

Extract the zip and follow the instructions on how to update the plugin (make sure you remove the old version before you try)

keombre commented 7 years ago

Nice to hear, that the plugin works @srid99 BUT!! updating any plugin in Chrome from simple .ZIP package doesn't work the same as a native extension. IF you want to add the updated extension (from zip, on Windows) you need to repack it to .CRX, install GPO tools for Chrome, add extension and finally white-list it, to enable it without popups. (sry. but I won't link it, since it's quite a hidden feature mainly for DEVs and SysAdmins)

I understand, why devs at Google made it that way, however, it makes our job (as independent devs) unimaginably harder :(

Snuggle commented 7 years ago

Unfortunately, it appears that the original developer has gone the way of the dodo. :cry:

The project is MIT-licensed, so if anyone's up for taking over and maintaining this project, I think you're perfectly fine to do so. Personally, I'm going to stop using this extension and use "Overlay Scrollbars" in chrome://flags. It looks pretty similar and means I won't have to use an abandoned extension. c:

LeBaux commented 7 years ago

Will this be merged @iaarchiver? 🤔 Or is there someone knowledgeable to fork and release it, maybe @keombre?

keombre commented 7 years ago

I've just learned about chrome://flags/#overlay-scrollbars, thanks @Snuggle so much! I've switched immediately, therefore I won't maintain this, sorry @LeBaux.

Snuggle commented 7 years ago

No problem! ❤ It's almost identical and is supported within chrome. c:

prakharb5 commented 3 years ago

@keombre I have come from the future, looking for this. No doubt this is a cool project. It needs to be updated, as Overlay Scrollbars are officially dead as of November 2020. Please update this app.