iabdelkareem / csharp.nvim

Neovim plugin written in Lua, powered by omnisharp-roslyn, that aims to enhance the development experience for .NET developers.
MIT License
226 stars 12 forks source link

fd vs fdfind, plugin breaks on ubuntu system #20

Open Ren-B-7 opened 5 hours ago

Ren-B-7 commented 5 hours ago
          To further complicate things, fd doesnt work on ubuntu, since the fd name was already taken, they named it fd-find, which somewhere gets shortened to fdfind, meaning that the plugin wont ever find the working dir when using an ubuntu system...   

This explains why even though there is provision for single file mode, the plugin wont work when you are not in a .csx folder.

Sadly a simple alias fd="fdfind"

Doesnt work for me. Since i use Zsh i also cant export the fd as a function to a subshell.

Maybe a bit of a hack would be to change the file search to
iabdelkareem/csharp.nvim/tree/main/lua/csharp/modules/lsp/omnisharp.lua -- line 13

local root_dir = vim.fn.systemlist((vim.fn.executable("fdfind") == 1 and "fdfind" or "fd") .. " -e sln . " .. vim.loop.cwd())[1]

Originally posted by @Ren-B-7 in https://github.com/iabdelkareem/csharp.nvim/issues/19#issuecomment-2479646618

Ren-B-7 commented 5 hours ago

Issue is discussed here https://github.com/sharkdp/fd/issues/1009
This issue is for debian and ubuntu ... fun

Pull request here - #21

Proposed changes and updates, tested locally on ubuntu system, recommend testing on another unix based system.

Maybe its time for a checkhealth plugin checking dependencies?