search

iabudiab / HTMLKit

An Objective-C framework for your everyday HTML needs.
MIT License
239 stars 27 forks source link

Implement DOM Ranges #2

Closed gneil90 closed 7 years ago

gneil90 commented 7 years ago

Could we please discuss implementing DOM range feature? I would be pleased to contribute for this part of project

iabudiab commented 7 years ago

Hey, of course we could. And if you want to help, even better 👍

I would start by reading and understanding the relevant specification and all that is necessary for DOM Ranges to be implemented.

I don't know how deep you are already are in the code base, but a good starting point would be to introduce the length property for HTMLNode and its subclasses.

The trickiest part in my opinion are the DOM mutations and their effects on the ranges and vice versa. I'll get back to you once I've read the spec and analyzed it.

Let me know if you have any further thoughts. Will be glad to discuss them.

iabudiab commented 7 years ago

DOM Ranges are implemented now in the develop branch 🎉 (more specifically this commit: 542bc26ff9b38c8d792093633daf676db3fc615e) I'll release v1.1.0 as soon as I've done some housekeeping.

Closing this issue for now. For bugs or problems related to DOM Ranges please open new issues.