add touch pad from Xiaomi Mi Notebook Pro

[mikey0000]

04f3:0c1a is the device ID, I am happy to compile etc to test. Even write code once pointed in the right direction. Thanks.

[timber-they]

Same here

[iafilatov]

@mikey0000 For now you can refer to frpint mailing list. There's a number of threads which could help https://lists.freedesktop.org/archives/fprint/2017-March/000868.html https://lists.freedesktop.org/archives/fprint/2017-November/000893.html https://lists.freedesktop.org/archives/fprint/2017-November/000895.html https://lists.freedesktop.org/archives/fprint/2018-January/000920.html

This commit contains an entire set of changes needed to add a completely new driver. If there's already one for a similar device, it should require even less changes.

In general, you'd need to

1. Reverse-engineer the protocol that your device uses to start the device, capture an image of the finger and deactivate.
2. Code up a driver that would send the commands. libfprint in general doesn't care what the driver does. It calls the 'activate' subroutine and waits for the driver to submit the image. It can also call 'deactivate' at any point and the driver should handle it gracefully.
3. Check that everything works in libfprint/examples, fprint_demo and frpintd (the daemon which handles fingerprint auth).

[mikey0000]

Thanks I'll take a look soon.

On 9 January 2018 21:47:24 GMT+13:00, Igor Filatov notifications@github.com wrote:

@mikey0000 For now you can refer to frpint mailing list. There's a number of threads which could help https://lists.freedesktop.org/archives/fprint/2017-March/000868.html https://lists.freedesktop.org/archives/fprint/2017-November/000893.html https://lists.freedesktop.org/archives/fprint/2017-November/000895.html https://lists.freedesktop.org/archives/fprint/2018-January/000920.html

This commit contains an entire set of changes needed to add a completely new driver. If there's already one for a similar device, it should require even less changes.

In general, you'd need to

1. Reverse-engineer the protocol that your device uses to start the device, capture an image of the finger and deactivate.
2. Code up a driver that would send the commands. libfprint in general doesn't care what the driver does. It calls the 'activate' subroutine and waits for the driver to submit the image. It can also call 'deactivate' at any point and the driver should handle it gracefully.
3. Check that everything works in libfprint/examples, fprint_demo and frpintd (the daemon which handles fingerprint auth).

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/iafilatov/libfprint/issues/2#issuecomment-356218167

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[mikey0000]

on a side note, testing with fingerprint gui, it recognised the swipe when I selected the unknown device (elan) so the existing driver should be a good starting point.

[EDIT]

I've tried out the fprint-demo with having added the correct device id and it is working, I think the frames for the fingerprint might need minor adjusting but it successfully recognises and scans. I'll PR soon with the minor change.

[iafilatov]

Thanks. We now have a lot more info on the protocol and modes of these readers (see the mailing list). Hopefully I'll be able to integrate it into the driver soon.

[Garuda44]

I also have request for the support of fingerprint sensor at Xiaomi Mi Notebook. If I could help somehow I'll be happy to do it, but I cannot do reverse engineering.

[joaquinvacas]

Ok, Mi Notebook Pro here. Actually it... kinda works. But it requests to swipe the finger instead of tapping, fprint says: Enroll result: enroll-swipe-too-short ←← If you lift the finger fast. Enroll result: enroll-retry-scan ←← If you do not swipe it slowly, no matter how much you left the finger on the sensor, it requires to swipe.

[joaquinvacas]

Oh, and actually "img_capture" gets this, I don't know if this is normal or what.

finger.zip

[iafilatov]

@jknvv13 Well... there's a reason it wants you to swipe. Can't make these elans work otherwise. Please see https://bugs.launchpad.net/ubuntu/+source/libfprint/+bug/1641290/comments/41

[joaquinvacas]

This is a fprint issue or something on the driver actually?

[joaquinvacas]

This is a fprint issue or something on the driver actually?

[iafilatov]

This is because of the algo that libfprint uses for matching. It's common for all drivers. That algo works best when it has at least 60% of the fingerprint. Compare that to the area that your reader can cover. In my case it's 20-25%.

[joaquinvacas]

And can this be solved or this will be stuck forever in a "swipe" world? 🤦‍♂️

El mar., 30 ene. 2018 19:27, Igor Filatov notifications@github.com escribió:

This is because of the algo that libfprint uses for matching. It's common for all drivers. That algo works best when it has at least 60% of the fingerprint. Compare that to the area that your reader can cover. In my case it's 20-25%.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/iafilatov/libfprint/issues/2#issuecomment-361688330, or mute the thread https://github.com/notifications/unsubscribe-auth/AEMyJiA7KyBjCItirxVazckVgxxIhB23ks5tP18fgaJpZM4Q8VDo .

[iafilatov]

It can if someone implements a different algo or finds a usable lib that can be distributed with libfprint. Not a simple task. I wouldn't say "forever" but for now it's gonna be swipe.

[Garuda44]

Sorry but my Xiaomi doesn't see the device.

[iafilatov]

@Garuda44 I've added more devices to the supported list. Could you please try the latest code?

[Dreamwork57]

First, I wanna thank you all for trying to bring elan fingerprint readers to work.

I've tried out this driver for my Xiaomi Mi Notebook Pro, because I needed a driver that worked with the fingerprint reader. Right now it does work, meaning it recognize the hardware, and my finger (that's the good part). Now, beyond the fact you must swipe to use the sensor, it also cannot log me. And of the top of that, if I swipe too quickly, I've got the error mentioned by @jknvv13 :

Enroll result: enroll-swipe-too-short ←← If you lift the finger fast.

The problem is that when I got this error, the fprint doesn't react anymore, it just kind of freezes and so I cannot log. Also another bug (wich I think is more because of sddm) : everything I described until now is when I log just after closing the session. But when I restart my computer, I cannot use fingerprint to log AND the password doesn't work at all. But I think it's really a bug in sddm.

[iafilatov]

@Dreamwork57 Can you please post the logs from examples/enroll and examples/verify? There's also the last enrolled image from examples/enroll called enrolled.pgm. If you don't mind, could you please send it to me ( my github handle at gmail )? If you do, please just describe what you see. Assembling of frames should work correctly with the latest code but from what people report, I still have doubts.

The various XYZDM's indeed lack a good integration with fingerprint devices. If the reader works fine, you normally don't get any problems. But if you need to fall back to password, yeah that's not always easy. Besides, passwords are still required for things like encrypted homes, keyrings, so...

[THMonster]

@Dreamwork57 I got the same problem. And I'm MiNote 13.3. It always get "swipe too short" and doesn't respond any more. This problem makes it hard to enroll a fingerprint. Although I have enrolled my fingerprint successfully five times, I cannot verify my fingerprint correctly.

[iafilatov]

It always get "swipe too short" and doesn't respond any more.

Ok, found it. Should be fixed by f6f6bb4.

Still, the message means that the swipe should be "longer". The only metric the driver has is the number of frames captured. This number depends on the time you spend swiping, not how far the finger travels (but this is also important!). For ex. I need to do the entire swipe in no less that 2 sec. I can do it in 1 sec but that's not enough to capture the minimum required number of frames.

[mikey0000]

Awesome that should fix my issues too.

On 26 February 2018 22:27:49 GMT+13:00, Igor Filatov notifications@github.com wrote:

It always get "swipe too short" and doesn't respond any more.

Ok, found it. Should be fixed by ea406e4.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/iafilatov/libfprint/issues/2#issuecomment-368439226

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[Dreamwork57]

Thanks for the answer and the fix, I'll test it as soon as released. It would be great to make this sensor work.

[iafilatov]

This won't get to the upstream for a while. The only way to use it (except with 0907) for now is to clone this repo, build and install.

[THMonster]

@iafilatov Thanks for your effort. After some tests, I think it has fixed freezing on enroll with swipe too short. But on verifying, when I get "swipe too short", it will be freezed without any retry.

[iafilatov]

Ugh... fixed that as well. I've recently moved to a more event-driven approach but it appears that fprintd doesn't utilize it fully yet.

[THMonster]

@iafilatov GREAT! It works perfect. Thank you very much!

[iafilatov]

@mikey0000 @Dreamwork57 Please see if you still have the lock-ups, if not, I'll close this issue.

[Dreamwork57]

@iafilatov I won't be able to test it out until this very afternoon (in 8-9hours, don't know were you're located) So i'll tell you then

[mikey0000]

I'll give it a go

On 28 February 2018 20:42:53 GMT+13:00, Dreamwork57 notifications@github.com wrote:

@iafilatov I won't be able to test it out until this very afternoon (in 8-9hours, don't know were you're located) So i'll tell you then

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/iafilatov/libfprint/issues/2#issuecomment-369148913

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[Dreamwork57]

Ok so now it actually works, the enroll is working perfectly but I still have some problems to login with the fingerprint. Pretty sure that it doesn't have anything to do with the driver, but if someone could give me an answer, I'll be thankful : When I lock the computer and then try to login, at first I can't use the fingerprint (it doesn't work, doesn't make any life sign) so I tap my password and it asks me to log with fingerprint. I do it, it works and I must again hit "Enter" to be logged in. Maybe it as to do with my pam conf I don't know. If someone can help me contact me in private. I use debian 9 stretch by the way.

[mikey0000]

the fprint-demo app doesn't seem to work now. Dunno whats going on there, however the fingerprint-gui works great. Scanning is definitely working well as well as verifying. Will check login. I'm on Lubuntu so not that easy to enable..

[mikey0000]

having udev issues trying to get fingerprint-gui to work without sudo.. getting there. Turns out the bus device ownership needed changing from root:root to root:plugdev.

Login works great. @Dreamwork57 check /dev/bus/usb/.../... permissions and group is set to plugdev lsusb will show you the numbers to follow. i.e mine is /dev/bus/usb/001/005 Bus 001 Device 005: ID 04f3:0c1a Elan Microelectronics Corp.

also make sure your user has plugdev group sudo usermod -a -G plugdev username

[kjhoerr]

Not sure if a different Arch group exists for managing devices, but I added the plugdev group as @mikey0000 mentioned. In Arch you can't just change group/ownership of a device though, since that gets reset when rebooting. I had to create a rules file for udev:

# /etc/udev/rules.d/elan-fprint.rules
ATTR{idVendor}=="04f3", ATTR{idProduct}=="0c1a", GROUP="plugdev"

Then all that was required then was making sure that udev could read the new rules:

# udevadm trigger

And it started working automatically!

[arogozhnikov]

Hey, as some kind of feedback - I've successfully installed the latest version on mi notebook pro, but verification results in too many false negatives (1 successful in ~10 attempts)

[fr33mang]

Hi everyone, can u make full instruction? I can't activate fingerprint on my Xiaomi mi notebook pro with Manjaro KDE, because Fingerprint GUI app doesn't see fingerprint module..

[LordJABA]

be sure to uninstall/purge the lib installed from system repos, I had the same and this solved the issue. If you want I can give you trimmed bash_history dump on my successful attempt on kubuntu 18.04

[kovalenp]

@LordJABA yes please, I wonder how I can enable fingerprint reader in 18.10

[Drun555]

04f3 in Xiaomi Notebook Pro is completely unusable. Is here any moves in last months?

[andirsun]

04f3 in Xiaomi Notebook Pro is completely unusable. Is here any moves in last months?

Bro I have The same laptop, how can I activate my fingerprint with fingerprint gui ? im in elementary os