search

iafilatov / libfprint

libfrpint driver for a family of Elantech fingerprint sensors
https://cgit.freedesktop.org/libfprint/libfprint/
GNU Lesser General Public License v2.1
146 stars 20 forks source link

add support for elan 0C1A #4

Closed mikey0000 closed 6 years ago

mikey0000 commented 6 years ago

seem to be getting cases where the device isn't being closed properly which stops fprint-demo from working as it can no longer open the device. Any clues where I should start looking? [EDIT] I'm a muppet nevermind! I left another instance of fprint-demo open.

iafilatov commented 6 years ago

Please see if the latest commit in elan works for your device.

mikey0000 commented 6 years ago

Hi it doesn't pick up the device for example I get elan when I select show drivername on fingerprint GUI. Nothing when I build latest elan on your branch.

You are missing the vendor and product id for mine and the others you've added.

{.vendor = ELAN_VENDOR_ID, .product = 0x0c1a, .driver_data = ELAN_0C1A},

[EDIT] I added the code above and tested out your branch.

  1. It does work
  2. Its much harder to enroll after your latest changes vs where my branch is at.
iafilatov commented 6 years ago

True, I forgot to add device ids. Fixed.

What do you mean harder? Does it error out or say 'stage not passed' or something like that? Could you post the logs please?

iafilatov commented 6 years ago

Just a guess but the calibration step has been reworked and that could cause your device to produce worse images somehow. Can you please try adding it to https://github.com/iafilatov/libfprint/blob/17cc36ed8a0ff5219b3b2b98abfe22e4bdb5dbc4/libfprint/drivers/elan.c#L443 and see if it helps?

mikey0000 commented 6 years ago

alright I'll give it a go.

mikey0000 commented 6 years ago

it seems when the room is too hot it won't work at all (which it used to). will verify tonight hopefully.

iafilatov commented 6 years ago

Oops, I'd made a typo that cause the driver to skip calibration on all devices... Fixed now.

iafilatov commented 6 years ago

Closing because the device is now recognized.