iag-geo / psma-admin-bdys

Some utils to make it easier to use the PSMA's Administrative Boundaries
Apache License 2.0
16 stars 4 forks source link

Added new sa4-boundary-table argument #12

Closed nathanscully closed 7 years ago

nathanscully commented 7 years ago

Description

Added in a new command line argument, 'sa4-boundary-table' to support using different SA4 tables for the state/coast line boundaries.

Motivation and Context

With the release of the 2016 ASGS boundaries, we have newer coastlines and borders. I wanted to be able to utilise these new boundaries with the existing cleaning process.

The PR defaults to the new 'abs_2016_sa4' table. You can use the existing 2011 table by supplying the following argument:

--sa4-boundary-table abs_2011_sa4

How Has This Been Tested?

Tested locally using the default and the new command line. Both generate correctly with no invalid geometries.

Other Affected Components:

The 2016 SA4 table was failing on the '05-finalise-display-localities.sql' step due to an invalid geometry. I altered the buffer from -0.00000001 to -0.00000002 in the 'temp_holes_distinct' step.

minus34 commented 7 years ago

Thanks Nathan!