search

iag-geo / psma-admin-bdys

Some utils to make it easier to use the PSMA's Administrative Boundaries
Apache License 2.0
16 stars 4 forks source link

Merge into gnaf-loader? #8

Open nyalldawson opened 8 years ago

nyalldawson commented 8 years ago

There seems to be a big overlap in both code and functionality between this and gnaf-loader. Do you think it's worthwhile merging this script into gnaf-loader, and make it an optional step via a command line argument?

ghost commented 8 years ago

Sounds good, I'm just trying to get the locality-clean process down from 2 hours to ~30 mins so as to not blow out the gnaf-loader process to multiple hours. Hopefully have it done in the next day.

nyalldawson commented 8 years ago

Nice! I'm happy to lend a hand too but wasn't sure what the status with this project/the gnaf-loader was. I'll see if I can spot any potential optimisations when I get a free moment :)

ghost commented 8 years ago

Ok, new improved ~30-45 min process has been comitted (down from ~2hrs). Downside is that PostGIS 2.2 is now mandatory (due to use of new - and awesome - ST_Subdivide function). Feel free to integrate with gnaf-loader if you've got some free time coming up.

nyalldawson commented 8 years ago

Thanks - let me see what I can do :)

ghost commented 7 years ago

Code has been refactored along with gnaf-loader to separate common defs into psma.py. First stage is complete...