search

iagodahlem / tiempo

:clock1: Pomodoro app for the modern web.
https://tiempo.iagodahlem.com
MIT License
11 stars 4 forks source link

Feature/show session info in title #21

Closed jprask closed 5 years ago

jprask commented 5 years ago

closes #15

Before:

tiempo-tit-before

After:

tiempo-tit-after

jprask commented 5 years ago

eslint is not happy about emoji a11y: Emojis should be wrapped in <span>, have role="img", and have an accessible description with aria-label or aria-labelledby

I think since they are in title it's not a concern... we could // eslint-disable-next-line it or use something like 25:00 | Pomodoro

iagodahlem commented 5 years ago

I really liked the emojis on the title, I think we can try to use Unicode for the emojis instead of placing them directly, this we also show the emoji type for the system the user is using.

Not sure if it works, but I think it's worth the try.

We can try to search for the emojis Unicode here.

codecov-io commented 5 years ago

Codecov Report

Merging #21 into master will decrease coverage by 1.05%. The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   51.44%   50.38%   -1.06%     
==========================================
  Files          29       30       +1     
  Lines         381      391      +10     
  Branches       41       41              
==========================================
+ Hits          196      197       +1     
- Misses        167      176       +9     
  Partials       18       18
Impacted Files Coverage Δ
src/pomodoro/containers/PomodoroLapse.js 0% <ø> (ø) :arrow_up:
src/pomodoro/components/PomodoroPage.js 0% <ø> (ø) :arrow_up:
src/pomodoro/containers/PomodoroTitle.js 0% <0%> (ø)
src/pomodoro/containers/index.js 0% <0%> (ø) :arrow_up:
src/pomodoro/store/index.js 92.15% <100%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 453157c...76823da. Read the comment docs.