search

iagox86 / dnscat2

BSD 3-Clause "New" or "Revised" License
3.4k stars 599 forks source link

Suggestion for improvement #145

Open anonymouz4 opened 4 years ago

anonymouz4 commented 4 years ago

I'd suggest to change 

typedef enum
{
  FALSE,
  TRUE
} NBBOOL;

to sth like

typedef enum
{
  _FALSE,
  _TRUE
} NBBOOL;

and all corresponding occurrences.

the problem with the first one is that you can't #include <mach-o/dyld.h>, it would see it as redeclaration of TRUE/FALSE.

So problems would occur when integrating the code in other projects.