search

iai-group / MovieBot

IAI MovieBot
https://iai-group.github.io/MovieBot/
MIT License
8 stars 10 forks source link

Add unified intent/slot filling model #198

Closed IKostric closed 1 year ago

IKostric commented 1 year ago

Fixes #197

github-actions[bot] commented 1 year ago
Current Branch Main Branch
Coverage Badge Coverage Badge
IKostric commented 1 year ago

Mostly minor nits but I didn't see tests for some of the new code. Is it already covered?

Created a new issue for tests

I would suggest to rename test_nlu.py to test_rule_based_nlu.py. Maybe a follow-up issue can be created to give the option to load different types of NLU (i.e., rule based, neural) based on the configuration

Done