search

iai-group / guidelines

IAI Style Guide
7 stars 4 forks source link

Update repos with mypy and docformatter #46

Closed kbalog closed 1 year ago

kbalog commented 1 year ago

Depends on #44

NoB0 commented 1 year ago

Done for UserSimCRS in PR #80.

NoB0 commented 1 year ago

Done for template repository, see PR #2

NoB0 commented 1 year ago

@IKostric Are mypy, docformatter, and pydocstyles in pre-commit for arXivDigest? If so, can you please close this issue.

IKostric commented 1 year ago

arXivDigest is an older repo that doesn't follow our current template. It has no pre-commit. ArxivDigestAssistant is updated to the latest version.

@kbalog Should I make issues to update arXivDigest to follow our templates? This would involve running black, flake8, mypy, and redoing docstrings to follow Google doc-style.

kbalog commented 1 year ago

You could create an issue about it -- but doing the actual work would be ideal for a bachelor project (among other updates/extensions to arXivDigest)

NoB0 commented 1 year ago

I created a follow-up issue #70 for arXivDigest.