Issue 118 - Githubissues

iainbrighton / PScribo

PowerShell documentation framework

MIT License

230 stars 35 forks source link

Issue 118 #125

Closed carceneaux closed 1 year ago

carceneaux commented 1 year ago

Fixes #118 Fixes #123

Added additional logic to properly handle an error where the incorrect number of ColumnWidths was specified
Added a unit test to validate the newly applied logic during builds
Updated example documentation accordingly

iainbrighton commented 1 year ago

@carceneaux rather than fixing the PSScriptAnalyzer version, can you just add an additional [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidMultipleTypeAttributes','')] attribute to the Set-Style.ps1 function (and reverse the appveyor.yml change)?

From my testing, it appears that it is only that one function that currently flags this new rule. Do this will ensure that new tests and module updates are included in future.

iainbrighton commented 1 year ago

@carceneaux oh, the other changes look good 👍

carceneaux commented 1 year ago

@iainbrighton Changes made as requested and unit tests are passing. PR should now be good to go.