search

iainbrighton / PScribo

PowerShell documentation framework
MIT License
232 stars 35 forks source link

Page orientation landscape #5

Closed irwins closed 8 years ago

irwins commented 8 years ago

Having landscape as page orientation would be nice! ;-)

simonbyles commented 8 years ago

This would be incredibly useful. I'm using PScribo for tabular reports so portrait orientation can be restrictive.

iainbrighton commented 8 years ago

@irwins @simonbyles There is now a GlobalOption -Orientation Landscape option. Version 0.7.8 has been pushed to the PowerShell Gallery! Enjoy :smiley:

simonbyles commented 8 years ago

Thanks. The new Landscape works perfectly and makes my report looks much better.

There is one minor issue in the new version: the portrait option has been misspelt as Potrait.

iainbrighton commented 8 years ago

DOH. Genius! Good job it's the default ;). Thanks for the heads-up, I'll get it fixed.

iainbrighton commented 8 years ago

@simonbyles @irwins I've updated the dev branch with the fix. I won't push this to master/gallery until there are more commits (or unless someone shouts otherwise!).

simonbyles commented 8 years ago

Thanks

On Tuesday, 31 May 2016, Iain Brighton notifications@github.com wrote:

@simonbyles https://github.com/simonbyles @irwins https://github.com/irwins I've updated the dev branch with the fix. I won't push this to master/gallery until there are more commits (or unless someone shouts otherwise!).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/iainbrighton/PScribo/issues/5#issuecomment-222668323, or mute the thread https://github.com/notifications/unsubscribe/AHWrNlQec5RiBLaHU-mJlBnjI-HXBEgJks5qHCM4gaJpZM4IGayU .

michaeltlombardi commented 8 years ago

@iainbrighton: Since you're following SemVer anyway, I don't see any reason not to move forward and release 0.7.9 with this patch.