Add Image support - Githubissues

iainbrighton / PScribo

PowerShell documentation framework

MIT License

231 stars 35 forks source link

Add Image support #51

Closed matt2005 closed 7 years ago

matt2005 commented 7 years ago

Added Support for images in Word.

iainbrighton commented 7 years ago

@matt2005 An awesome contribution! Couple of things:

There appears to be no test coverage for the new methods.
- Can you add some tests for the new image functions?
I'm struggling to digest all the changes as the bracing style and spacing has changed (from 4 spaces to 2 spaces).
- This means that I'll probably need to merge it into a separate branch before merging into dev. Are you happy to resubmit the PR into the Image branch?

matt2005 commented 7 years ago

I have some tests written, I just haven't completed them yet. Also I cannot run the psake script due to missing module "VirtualEngine.build" which contains several functions that are required.
This is due to ISESteroids Auto-format. Do you want me to redo my changes without putting it thorough auto format?

iainbrighton commented 7 years ago

@matt2005 You can run the tests by running Invoke-Pester -Script .\Tests. The VirtualEngine.Build module is only needed when packaging/building the module for release/publishing.

Don't worry about reformatting as I can get VSCode to do this for me. If you can push your PR to the Image branch, we can work on it there?

Thanks for your contribution 😃!

matt2005 commented 7 years ago

Resubmitted into image branch #52