search

iaincollins / docker-deploy-webhook

A Docker Service for Continuous Deployment (Git Hub -> Docker Hub -> Docker Swarm)
https://medium.com/@iaincollins/docker-swarm-automated-deployment-cb477767dfcf
ISC License
96 stars 35 forks source link

Optional credentials #3

Open InDieTasten opened 6 years ago

InDieTasten commented 6 years ago

As far as I can see, the only reason for having to provide credentials for this software is to be able to pull images from private repos on docker hub.

Would it be possible to make the software not crash, but skip docker login, if the credentials are omitted? This way, one wouldn't have expose credentials and having to keep them updated, if passwords change, etc.

InDieTasten commented 6 years ago

I'd be willing to create a PR, if there was a suitable license for me to do that.

levino commented 6 years ago

What is the usecase? You want to redeploy your mongodb everytime a new image is pushed? I think it is quite unreasonable to automate redeployment for images you do not control / which are public. You should do this for your apps, not your dependencies.

imjosh commented 6 years ago

The use case is for images that you control that are also public. Or, if you want to live by the seat of your pants and re-deploy mongo whenever they update their image, that's your choice to make.

InDieTasten commented 6 years ago

For me personally, that is exactly the case. I have a public repo I control, and I don't want to put my credentials at yet another place. It's a demo service, which will be updated frequently and I like to automate my processes such that completing a PR to my master will CI and CD straight to the demo slot.

iaincollins commented 6 years ago

Thanks for raising this and for the PR! 💯