iaincollins / icarus

ICARUS Terminal for Elite Dangerous
ISC License
164 stars 11 forks source link

Some landable planets not showing as landable in Navigation panel #40

Closed iaincollins closed 1 year ago

iaincollins commented 1 year ago

As reported here, some systems have planets that are landable, but the Navigation Map and List views do not indicate they are landable:

https://forums.frontier.co.uk/threads/icarus-terminal-pre-release.594667/page-15#post-9977466

Examples of systems / bodies:

Since this report, I've seen this bug first hand in other systems.

I'm sure it's because there is data in EDSM from these planets that pre-dates the release of Odyssey and these planets were recorded in EDSM as not being landable, because they were not at the time.

What I'm not sure of is if the problem is ICARUS Terminal is showing older data from ESDM incorrectly (that has been an issue before) or the issue is EDSM persisting older data and not updating when a system is scanned again and has changed.

iaincollins commented 1 year ago

When I went to Outopps UB-K c22-2 I found 3 bodies that were marked as not landable.

After scanning them (with the data automatically submitted to EDSM by EDDI) they immediately updated in ICARUS Terminal (and in ESDM) to show as landable bodies!

This was not my previous experience of this bug, when I encountered it myself submitting data to EDSM/EDDN did not seem to cause the body to be updated (which is also what the user who reported this issue experienced).

If it turns out that was just down to a glitch with ESDM and normally the system will update when next scanned then it's not a huge deal. I would like to investigate further through to determine if that really does seem to have bene the cause (but that will require some targeted exploration, so might be a while before I get round to trying to replicate it).

A potential fix might be to look at the properties of the planet, and to look at the atmosphere density and if it otherwise meets the criteria for a landable body to override the flag and display it as such. The catch with that is I'm not 100% sure of the criteria (is it just body type and atmosphere density? I don't think gravity or size actually factor as you can land on 45g bodies...)

iaincollins commented 1 year ago

I travelled to HIP 96438 and was able to confirm that as long as something that is posting back to ESDM that it should be updated correctly.

Before Scanning

Before scanning, the system data in ESDM was not correct (Planet A 5 was not shown as landable).

Screenshot (3347)

After Scanning

After scanning with EDDI submitting to EDSM, the system now shows correctly.

Screenshot (3348)

iaincollins commented 1 year ago

Happy this issue as resolved as it's ever likely to be, so closing off.

A future update may indicate if a scan appears to be old and if the data may be outdated, to prompt folks to scan the system and submit updates.