search

iaincollins / icarus

ICARUS Terminal for Elite Dangerous
ISC License
169 stars 11 forks source link

Icarus launcher shows (possibly) wrong IP address for the browser connection #51

Open alyyasser opened 1 year ago

alyyasser commented 1 year ago

image I was trying to open a terminal on my tablet, and then i realized that the IP address shown on the launcher was incorrect. it was neither my local IP address, nor my public one.

iaincollins commented 11 months ago

Thanks for flagging this!

What's going on here is that it grabs the first IP address on an interface it finds and suggests that. Sometimes that's a weird internal address on a virtual adapter or a VPN interface or something like that.

It used to display a list of all known IP address but because that was confusing and there isn't currently space in the UI to handle multiple address, I changed it to just display the first address as that works okay for 90% of folks. I should get around to addressing that though so will leave this open.

alyyasser commented 9 months ago

sorry for the very late update, it seems like you were right, the issue were surfaced when i have my vpn on, when i turned it off, it works normally. probably should filter the network interfaces by only LAN or Wi-Fi if possible.

Rum-Monk commented 2 months ago

Just adding to this that it would be nice to have the option to manually specify the IP and port.

I ran into the same issue. Luckily, once the launcher is running it will stick with whichever IP it originally picked. So disabling the VPN, launching ICARUS. then enabling the VPN after allows you to still have the VPN going with ICARUS.