iaincollins / structured-data-testing-tool

A library and command line tool to help inspect and test for Structured Data.
https://www.npmjs.com/package/structured-data-testing-tool
ISC License
63 stars 14 forks source link

New Schema.org tests should work with nested objects #19

Open iaincollins opened 4 years ago

iaincollins commented 4 years ago

Describe the bug The new Schema.org property tests - that check if property names valid or not - should work with nested objects.

Note: Applies to the new Schema.org property tests are in master but not in the release version.

To Reproduce Nested property names (ie any property that is not a top level property) are not currently checked for validity. See existing invalid properties fixture for an example of an error that is not caught (only some of the errors in the example are caught by the current tests).

Expected behaviour Nested property names should be checked to see if they are valid and should raise an error if they are not valid on a nested property. This might prove tricky to implement as some properties can be one of many different types and that might complicate the logic.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

lordscarlet commented 4 years ago

Note: Applies to the new Schema.org property tests are in master but not in the release version.

Does this mean this bug is not present in v4.5?

iaincollins commented 4 years ago

Can confirm yes this bug is not in the currently released version just in the master version - the current version does not check property names for validity at all (just reports what it finds).

This is my fault for merging the work for the next release (5.0) into master instead of pushing to a separate branch.