search

iainjreid / hapi-apn

📲 Apple Push Notifications from your Hapi applications using Node APN
0 stars 2 forks source link

Fix memory leak allowing infinite amount of listeners #1

Closed leovido closed 6 years ago

iainjreid commented 6 years ago

After reading around this ticket from the APN repository, it seems that adding to the maximum listeners isn't quite enough, I'd recommend adding this fix!

I can implement this or you can, your call buddy. Thanks for the PR though!

We need to store a reference to the connection and update it with a new provider every hour.

iainjreid commented 6 years ago

Hmm, actually this solution might not be the best, as timeouts will prevent services from shutting down gracefully. I can refresh the provider in the getter instead. That might be the best solution?

iainjreid commented 6 years ago

I've created an issue to track this! #2