search

iainurquhart / Nolan

Kinda like inception, but for Matrix.
1 stars 0 forks source link

Removing files #8

Open marcusneto opened 10 years ago

marcusneto commented 10 years ago

Uploading works great. At some point it would be nice to be able to specify the directory.

But the bigger issue is the removal of a file that has been uploaded. Currently that whole bit is busted. The thumbnail for a file does not show and the x you would regularly use to remove an associated file is missing.

I realize you did this quick before leaving for vacation so this is more of just a reminder to us both that this will need to be fixed. Hopefully soon :)

iainurquhart commented 10 years ago

If the thumbnail doesn't show (shows on my test) what path is it outputting to the image? Is there an image placeholder there that shows as broken, or the image is not there at all? (Inspect the element please)

Sent from my iPhone

On 7/08/2014, at 8:14 am, Marcus Neto notifications@github.com wrote:

Uploading works great. At some point it would be nice to be able to specify the directory.

But the bigger issue is the removal of a file that has been uploaded. Currently that whole bit is busted. The thumbnail for a file does not show and the x you would regularly use to remove an associated file is missing.

I realize you did this quick before leaving for vacation so this is more of just a reminder to us both that this will need to be fixed. Hopefully soon :)

— Reply to this email directly or view it on GitHub.

marcusneto commented 10 years ago

These are documents, remember? We dont need this for images.

iainurquhart commented 10 years ago

Well I asked if it was documents or images and I got crickets!

It's working around images only, but it's a simple fix to just output the file name instead of an image thumbnail.

Sent from my iPhone

On 7/08/2014, at 10:27 am, Marcus Neto notifications@github.com wrote:

These are documents, remember? We dont need this for images.

— Reply to this email directly or view it on GitHub.

marcusneto commented 10 years ago

It appears that DM did not go through. Sorry.