ialexivy / vscode-angular2-files

vscode extension generating angular files with angular cli
MIT License
61 stars 36 forks source link

Exclude node_modules so that the extension could fetch the right angular.json #60

Open JoeyLi-1 opened 4 years ago

JoeyLi-1 commented 4 years ago

Hi @ivalexa,

This extension is very useful. Thank you for creating such a great extension!

I found when fetch angular.json for the default config, the node_modules was not excluded. And the program found angular.json from /node_modules/@angular. That is not the angular.json from my project. Since I use 'less' rather than 'scss' for style file.

I would suggest that add the exclude pattern so that everybody could fetch their own config.

Like this: const files = await workspace.findFiles('{**/.angular-cli.json,**/angular.json}', 'node_modules/*', 1);

I tried to create a PR for you to review, but system told me I could not push a dev branch to remote. And that fix is quite simple. So, hope you can accept that. Thank you!

Thanks, Joey