search

ialokim / android-phone-field

A small library that allows you to create phone fields with corresponding country flags, and validate the phone number using libphonenumber from google.
Apache License 2.0
3 stars 6 forks source link

fixes problem of setPhoneNumber #1

Closed SubhamTyagi closed 5 years ago

SubhamTyagi commented 5 years ago

@ialokim this PR fixes the problem when any one set the phone number by calling setPhoneNumber(). i have find that isValid() creating the problem while pasting the number .

ialokim commented 5 years ago

the problem while we call setPhoneNumber(String rawNumber)

What is exactly not working with the current implementation? Could you provide an example where it is failing currently?

Regarding the validation when pasting numbers, I'm going to look into this.

ialokim commented 5 years ago

Okay, I've added some logic for better paste handling with f3c6ba. Can you check if this is working for you with release 0.2.2?

I'm going to close this PR.

ialokim commented 5 years ago

Please check out 0.2.3, there was an error building it on jitpack.

ialokim commented 5 years ago

@SubhamTyagi, did you update your dependency to 0.2.3? Is it working for you now?

SubhamTyagi commented 5 years ago

yes, it is working well.

ialokim commented 5 years ago

Glad to hear!