search

iam-Akshat / capstone-CarHub

A cars directory
0 stars 0 forks source link

peer-to-peer code review #2

Open rayking12 opened 4 years ago

rayking12 commented 4 years ago

i want to add a design issue, i think is better if you add some margin and padding to de elements because they are so close to others

rayking12 commented 4 years ago

You used Section so nice tag you can add article and aside tags also to your tags collection.

its best practices to put the variables at the top of your scss file

rayking12 commented 4 years ago

you have repeated flex a lot, you can create a mixin with parameters and use it in every selector that need flex.

rayking12 commented 4 years ago

you can organice your scss code, its better if your partes can understant what is in each part of the code, so we can give you a better code review partners* for example you can put a comment part with the title of the part you are styling