iam-py-test / my_filters_001

My filter lists - feel free to add these lists to uBlock Origin
https://iam-py-test.github.io/my_filters_001/
Creative Commons Zero v1.0 Universal
60 stars 9 forks source link

[bug] Cyrillic domain names should be converted to punicode #102

Closed nicolaasjan closed 1 year ago

nicolaasjan commented 1 year ago

What extention/adblocker/firewall do you have?

What list(s) are you using?

What is the issue?

Did you try updating your lists? This could fix the problem.

In the Alternative list formats/antimalware_pure_hosts.txt I found 7 domains written in Cyrillic, which can not be parsed in my hosts file. Found them by sorting the list alphabetically.

0.0.0.0 гослуги.рф
0.0.0.0 госсуслуга.рф
0.0.0.0 госсуслуугии.рф
0.0.0.0 госулуги.рф
0.0.0.0 госуслуги-госномера.рф
0.0.0.0 госуслуги-ру.рф
0.0.0.0 госуспуги.рф

I think they should be converted to punicode:

0.0.0.0 xn--c1aapkosp.xn--p1ai
0.0.0.0 xn--80afa5aosaarc.xn--p1ai
0.0.0.0 xn--c1aapamrvaatca.xn--p1ai
0.0.0.0 xn--c1aapkosob.xn--p1ai
0.0.0.0 xn----8sbhabmswnjffb4aeag2ac.xn--p1ai
0.0.0.0 xn----etbaunrsdatce.xn--p1ai
0.0.0.0 xn--c1aapwflapc.xn--p1ai

I used an online converter: https://www.punycoder.com/

For reference: https://discourse.pi-hole.net/t/how-to-unblock-specific-idn-domains/51237

github-actions[bot] commented 1 year ago

Hi, @nicolaasjan! Thank you for opening an issue!
@iam-py-test will get to this as soon as possible

nicolaasjan commented 1 year ago

B.t.w., These domains, except госуслуги-госномера.рф have expired.

iam-py-test commented 1 year ago

Thank you. The entries should now be converted to punycode automatically, and I removed the dead domains you mentioned.

nicolaasjan commented 1 year ago

Thanks! I've never seen an issue resolved so fast. 😀️ 🌻

Do you check for dead domains regularly?

iam-py-test commented 1 year ago

Do you check for dead domains regularly?

I try to, but (as you saw) it's really hit-and-miss. It's too big to check it all by hand and even automated tools take a while, so probably a good amount of the domains listed are dead.

I've never seen an issue resolved so fast.

Thanks.