iam-veeramalla / shell-scripting-projects

Projects on shell scripting. Goal is to simulate real time projects as much as posible.
712 stars 1.58k forks source link

Update s3-notification-triggers.sh to correct lambda ARN #1

Closed yogendra-kokamkar closed 1 year ago

yogendra-kokamkar commented 1 year ago

Hello Abhishek,

The "put-bucket-notification-configuration" block was failing as it was not able to identify the correct ARN for Lambda Configuration.

The issue was, The LambdaFunctionConfigurations code was considering everything under "Double quotes" as a plain text. Basically it was treating $aws_account_id as a plain text instead of a variable.

After changing the double quotes to single quotes, it was able to recognize $aws_account_id as a variable and the script ran without any error.

Please, have a review. Thank you for all your teachings, it's helping me a lot to pursue my career as a DevOps Engineer

iam-veeramalla commented 1 year ago

Hi @yogendra-kokamkar , Thanks for the PR but I fixed this issue already. Anyways, really appreciate your intent to contribute :)