feat: Adding discovery by filter

iam4x / bobarr

🍿 The all-in-one alternative for Sonarr, Radarr, Jackett... with a VPN and running in docker

MIT License

1.53k stars 88 forks source link

feat: Adding discovery by filter #82

Closed rasoul-shahriari closed 4 years ago

rasoul-shahriari commented 4 years ago

Bobbar is great, simple, and fast. :) I just added a section under the discovery section to make it possible to discover new movies bypassing some params to graphql.

I have added some services to fetch languages and genres from TMDB, and I cached them with Redis, I tried to follow your code standard.

iam4x commented 4 years ago

Hi @rasoul-shahriari, thank you very much for the kind words and the contribution!

bobarr is using yarn instead of npm for resolving dependencies, can you remove the package-lock.json and update the yarn.lock with yarn ?

I've added some comments as well in order to merge it, I'm going to check it out later today on my library.

Again thank you very much, this is highly appreciated 🙏

rasoul-shahriari commented 4 years ago

Hi @iam4x, Thanks for your comments, they make sense, I will fix them soon

rasoul-shahriari commented 4 years ago

@iam4x I just applied your comments, but for default language in the setting page, I guess we need to make it more strict because if the user enters something unmeaningful we will get an unexpected result from TMDB, for my component I get null names from API, I can take care of it if you want.

iam4x commented 4 years ago

Thank you, yes definitely this is in the roadmap and we can now re-use the languages GraphQL query you added to create the select for a better ui in the settings 👍

I think you are right, so let's set it english for now, and I'll change it when I will update the settings page ui.

iam4x commented 4 years ago

I have a suggestion based on this use case:

When you have an empty library, this looks pretty weird. I think we should split into two pages:

discover -> the feature you added
suggestions -> based on what you have in library

And maybe in the long term merge them back into subpages of the search.

This will simplify the usage not everything at the same place and we can edit the subtitle of the page to understand more what to do on this page, I'll let you find something cool :)

Otherwise, this is really awesome and pretty good feature :+1:

rasoul-shahriari commented 4 years ago

I liked your suggestion about breaking the discover page into two pages. it's done.

iam4x commented 4 years ago

Alright everything looks good for me, I'm going to test a last time the feature with your changes this evening before merging 👍

Thank you 🙌

rasoul-shahriari commented 4 years ago

Alright everything looks good for me, I'm going to test the last time the feature with your changes this evening before merging

Thank you

Don't even mention it, discover just works with movies, but I will add tv shows soon. By the way, what you are doing with modal and having more info is great. already in love with it.