Closed AlmirKadric closed 5 years ago
code lgtm. Can you post a screenshot?
Couple things...
Tried pulling this and react-bootstrap requires autocomplete.js, angular, and jquery which I had to install manually (not in package.json).
Secondly running this I received this error:
index.html:1 Uncaught SyntaxError: Unexpected token o in JSON at position 1
I'm new to node... so its quite possible I did something wrong.
@bateller I'm not sure where you got those dependencies from since I'm not seeing any such error. However if they truly are dependencies they need to be put inside the react-bootstrap
package.json
file. node
or rather so npm
will resolved dependencies of dependencies by looking at their package.json
. If you can provide me with the error or a screenshot of what got you to think they are dependencies, I'm happy to investigate it for you.
As for your error, thats most curious, mind telling me a bit about your environment? Node version, how you are seeing that error (electron developer console? browser console?) etc. More information would be helpful.
@MoOx here's the screenshot
When I try your branch I am getting an issue in the electron window:
index.html:1 Uncaught SyntaxError: Unexpected token o in JSON at position 1
. Any idea?
❯ node --version v5.12.0 ❯ npm --version 3.8.6
I did run "npm install" & got the new deps.
@MoOx that's most unusual. I deleted my node_modules folder and did a fresh re-install and everything seems to still work fine.
Did you checkout my branch as was? or did you merge it into an existing branch? Did you try deleting your node_modules folder and doing a fresh dep install? Did you do a electron refresh on the first start up? (electron is started before webpack builds so the first run will probably be using a stale pack) Could I get a screenshot? I might be able to derive what went wrong from this
I merge your branch into the current master (locally). I didn't do a full reinstall of node_modules I did an refresh electron refresh via "Reload" (I guess cmd+R is the same)?
@MoOx I just tried the following and still didn't see the error:
git checkout master
git pull upstream master
git merge feature/bookmarks
rm -rf node_modules
npm install .
npm run dev
Do you mind following that exact same process and seeing the results? If there is any part that doesn't make sense, let me know and I'll explain it.
@AlmirKadric Since @MoOx is seeing the same error I am, I figure I'd provide more information to help troubleshoot.
$ node --version
v6.3.1
$ npm --version
3.10.6
I too pulled from main and manually pulled in your branch.
The error was seen the same as @MoOx (in Electron Dev Tools)
@bateller mind trying the instructions in my last comment? I'm not seeing this, if you still are having issues after that, I'll try re cloning to project.
@AlmirKadric I tried with a fresh node_modules folder & a merge from current master, exact same issue. So a patch/change in a lib might broke something...
@MoOx @bateller i just went to the extremes to try and replicate your issue, but no luck. I will post my terminal output in a second so you can see how things went for me. They only suggestion I have to you is for you to check your local repo sanity and check if there is any difference to the upstream remote master.
What I would recommend is that you:
git fetch upstream
git branch test-branch upstream/master
git pull almir feature/bookmarks
rm -rf node_modules
npm install .
And if all else fails try and just clone directly from my repository. The only answer I can come up with right now is that the master branch you have locally is polluted and not the same as the upstream remote.
Thank's for the work @AlmirKadric, can you rebase on origin/master
branch and it should work 👍
Hello @AlmirKadric,
I tried following the instructions, by typing the commands stated in your terminal output.
Even if some Terminal outputs differ from your Terminal outputs stated above, I didn't get any error messages but for the last command "npm run dev":
npm ERR! file /Users/Ben0304/spoofing/PokemonGO/pokemongo-webspoof_implemented_bookmark_feature/package.json
npm ERR! code EJSONPARSE
npm ERR! Failed to parse json
npm ERR! Unexpected token < in JSON at position 1051 while parsing near '...eocoder": "^0.2.2",
npm ERR! <<<<<<< HEAD
npm ERR! "re...'
npm ERR! File: /Users/Ben0304/spoofing/PokemonGO/pokemongo-webspoof_implemented_bookmark_feature/package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.
npm ERR!
npm ERR! Tell the package author to fix their package.json file. JSON.parse
Do you still support your feature? If so, many thanks in advance for your help.
Kind regards, Ben0304
Allows you to save, search and select bookmarked coordinates I pulled react-bootstrap as the styles are being used, but the components were not. I also introduced a components folder for custom constructed components, in this case the combobox.
TODO:
.editorconfig
to have auto-configure certain styles (indentation)