search

iam4x / zsh-iterm-touchbar

Display feedback of terminal in the 🍏 Touchbar
MIT License
689 stars 75 forks source link

oh-my-zsh compatibility #1

Closed jtmkrueger closed 7 years ago

jtmkrueger commented 7 years ago

Is there a way to install this with oh-my-zsh? If so, can you add it to the readme? If not, any plans to add compatibility?

jtmkrueger commented 7 years ago

I tried cloning and adding source ~/.zsh/zsh-iterm-touchbar/zsh-iterm-touchbar.plugin.zsh to my .zshrc but I don't think it's working. Is there anything else I should need to do?

iam4x commented 7 years ago

Can you try to and give me the results?

Clone the repo in your plugins directory:

Then add the plugin into your ~/.zshr:

plugins=(... zsh-iterm-touchbar)
jtmkrueger commented 7 years ago

no, that didn't seem to do anything. It's still doesn't seem to be doing anything. Just to be clear, I'm using the iterm nightlies, so I don't think the compatibility issue is coming from there. I don't know if the pre_cmd() function is ever firing (maybe?)

iam4x commented 7 years ago

@jtmkrueger Can you try to rename pre_cmd() to precmd()?

jtmkrueger commented 7 years ago

ah, that seemed to start to do something:

precmd:23: command not found: spaceship_git_uncomitted
precmd:24: command not found: spaceship_git_unstaged
precmd:25: command not found: spaceship_git_untracked
precmd:26: command not found: spaceship_git_stashed
precmd:27: command not found: spaceship_git_unpushed_unpulled

showed up at the top of a new shell tab!

iam4x commented 7 years ago

Thank's will push a fix 👍

iam4x commented 7 years ago

Should be fixed on master, can you try again and give me result @jtmkrueger ?

jtmkrueger commented 7 years ago

looks like that did the trick!