search

iamDecode / sklearn-pmml-model

A library to parse and convert PMML models into Scikit-learn estimators.
BSD 2-Clause "Simplified" License
76 stars 15 forks source link

Support major release of scikit-learn 1.x #37

Closed iamDecode closed 2 years ago

iamDecode commented 2 years ago

Since scikit-learn officially released 1.0 the API has changed a bit. Mostly renaming, but sufficient for breaking sklearn-pmml-model. This PR resolves those issues while staying compatible with previous (recent) 0.x versions

height[bot] commented 2 years ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

codecov[bot] commented 2 years ago

Codecov Report

Merging #37 (24de56d) into master (186c065) will decrease coverage by 0.39%. The diff coverage is 92.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #37      +/-   ##
===========================================
- Coverage   100.00%   99.60%   -0.40%     
===========================================
  Files           16       16              
  Lines          967     1004      +37     
===========================================
+ Hits           967     1000      +33     
- Misses           0        4       +4
Impacted Files Coverage Δ
sklearn_pmml_model/naive_bayes/implementations.py 95.65% <50.00%> (-4.35%) :arrow_down:
sklearn_pmml_model/base.py 98.87% <66.66%> (-1.13%) :arrow_down:
sklearn_pmml_model/ensemble/forest.py 100.00% <100.00%> (ø)
sklearn_pmml_model/ensemble/gb.py 100.00% <100.00%> (ø)
sklearn_pmml_model/linear_model/implementations.py 100.00% <100.00%> (ø)
sklearn_pmml_model/svm/_base.py 100.00% <100.00%> (ø)
sklearn_pmml_model/svm/_classes.py 100.00% <100.00%> (ø)
sklearn_pmml_model/tree/tree.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 186c065...24de56d. Read the comment docs.

lgtm-com[bot] commented 2 years ago

This pull request fixes 2 alerts when merging 24de56d69d378bb386307880b487dbd2f7916598 into 186c0655b6b42b787d58229118b187cc6b156b38 - view on LGTM.com

fixed alerts: