search

iamacup / react-native-markdown-display

React Native 100% compatible CommonMark renderer
MIT License
568 stars 167 forks source link

Dependency updates (primarily React 17 and React Native 0.64.2) #147

Open inderdhir opened 3 years ago

smithydll commented 2 years ago

I don't think React Native dependency version needs to be updated, Expo has only just upgraded to 0.64.2 and this module works fine on older versions. Just needs React dependency changed to

"react": "^16.2.0 || ^17 || ^18"
baochungit commented 2 years ago

Please consider to merge it. Thanks!

JavanHuang commented 2 years ago

This is blocking the install of react-native-markdown-display on v0.66.3 of react-native, which requires v17.0.2 of react whenever we run npm install. It would be great if we could get this merged.

Alternatively, if anyone requires the 17.0.2 react update urgently, I found another package here that was forked from this repository updated with the changes in this PR: https://www.npmjs.com/package/@flowchase/react-native-markdown-display.

nicobermudez commented 2 years ago

Bump

HugDoggyDogg commented 2 years ago

Bump. Could really use this change

inderdhir commented 2 years ago

Just updated React/RN deps

nicobermudez commented 2 years ago

Can we merge this?

Gnative commented 2 years ago

Merge please

jkester1986 commented 1 year ago

@iamacup can we get this merged?

NilsBaumgartner1994 commented 1 year ago

push