iamacup / react-native-markdown-display

React Native 100% compatible CommonMark renderer
MIT License
608 stars 173 forks source link

allow react 17 #166

Closed trajano closed 11 months ago

kwnstantina commented 2 years ago

Is it possible to merge this PR?

pgdavidApodis commented 2 years ago

Would be great !

nicobermudez commented 2 years ago

Bump. Need this to be able to use Expo.

nicobermudez commented 2 years ago

@iamacup any updates on this one? Seems like a simple update

vini-coelho commented 2 years ago

Any updates on this one? Need it to upgrade to latest Salesforce SDK.

Tjerk-Haaye-Henricus commented 2 years ago

Hey there, Any Update ? Would be great if this would be merged

NilsBaumgartner1994 commented 2 years ago

push

chrisglein commented 1 year ago

@imacup There are many versions of this same change, coming from the error I imagine most of us are seeing:

warning " > react-native-markdown-display@7.0.0-alpha.2" has incorrect peer dependency "react@^16.2.0".

And if you npm list react, you'll see:

+-- react-native-markdown-display@7.0.0-alpha.2
| `-- react@18.2.0 deduped invalid: "^16.2.0" from node_modules/react-native-markdown-display

Other PRs doing similar things:

But of all of them... this one is the simplest. Seems like the least controversial merge.

iamacup commented 11 months ago

I have merged, will push a release shortly.

@chrisglein would you (or anyone else in this thread) be able to help fix this package up a bit?

I have not used React or React Native since hooks came in so i am really not best placed for it anymore.