iamantoniodinuzzo / CineMates

CineMates is a modern android application for movie fans in which you will be able to search for movies and consult information provided by The Movie DB.
GNU General Public License v3.0
15 stars 3 forks source link

Collection dialog crashes the app when a movie is selected #204

Closed iamantoniodinuzzo closed 1 year ago

iamantoniodinuzzo commented 1 year ago

Is there an existing issue for this?

Current Behavior

⚠This issue refers to a problem present in the develop branch, port to that branch

Selecting any movie that is part of a collection (Ant Man & The Wasp) and selecting the Collection section will open a dialog showing all the movies in the collection.

Clicking on one of these movies will crash the app because the action attached to clicking adapter elements attached to that recyclerview will not allow the NavController to be found.

This happens because the dialogs are shown in a view that is detached from the view of the nav controller and does not recognize any paths to the predetermined view.

Expected Behavior

When I click on a movie in the Collection dialog, the MovieDetails view must be recreated containing the information of the selected movie, just as if you were selecting a movie whose information you want to know.

Steps To Reproduce

  1. Select a movie from the home screen that is part of a saga or collection (for example, AntMan) or search for it in the appropriate section.
  2. Within the movie details screen ,scroll until you reach the collection section.
  3. Select the collection
  4. In the newly created dialog, select one of the movies present.

Relevant log output

No response

Anything else?

No response