Change qrand() , Use QRandomGenerator instead in QT > 5.10.0

gakramx commented 4 years ago

Sorry for Old Pull requests I was supposed to check it well So When trying to build with Cmake on my system :

Qt 5.15.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 10.1.0) on "xcb" 
OS: Arch Linux [linux version 5.4.49-1-lts]

The error message :


/home/akr/qtcsv/sources/writer.cpp:183:63: error: ‘int qrand()’ is deprecated: use QRandomGenerator instead [-Werror=deprecated-declarations]
  183 |         QString name = nameTemplate.arg(QString::number(qrand()));
      |

In QT documentation :

Note: This function is deprecated. In new applications, use QRandomGenerator instead. in QT > 5.10.0

https://doc.qt.io/qt-5/qtglobal-obsolete.html#qrand

After changing qrand() it was built without any problems .

gakramx commented 4 years ago

I agree QT_VERSION_CHECK more readable .

iamantony commented 4 years ago

Thanks @gakramx for your contribution!

gakramx commented 4 years ago

you are welcome @iamantony

iamantony / qtcsv

Change qrand() , Use QRandomGenerator instead in QT > 5.10.0 #63