search

iamantony / qtcsv

Library for reading and writing csv-files in Qt.
MIT License
265 stars 141 forks source link

Add support for Qt6 #66

Closed cristeab closed 3 years ago

cristeab commented 3 years ago

Tested on macOS 11.2. Running tests/qtcsv_tests gives a malloc corruption:

qtcsv_tests(29792,0x1076c0e00) malloc: Region cookie corrupted for region 0x7ff341c00000 (value is 0)[0x7ff341c0407c] qtcsv_tests(29792,0x1076c0e00) malloc: *** set a breakpoint in malloc_error_break to debug

iamantony commented 3 years ago

Wow, @cristeab thanks for the fix! Looks very good. The only thing that is bothers me is why tests are failing...

It seems that support of Qt6 brings a lot of ifdef-s in the code. Plus users will need to download special Qt5 Compatibility Module. I think this is not a user-friendly approach. Ideally qtcsv should need only core Qt lib that is available in every possible Qt "package".

Maybe a better approach would be to create a separate branch of qtcsv (based on current master) with Qt4/Qt5 support. And in master branch switch to Qt6.

cristeab commented 3 years ago

I will investigate to see why this crash happens. Qt6 has still many bugs and we should see this year Qt6.1 and Qt6.2 with many improvements

iamantony commented 3 years ago

Thanks!

markusdd commented 3 years ago

Before seeing this pull request I also tried building against QT6 and I second the idea of branching.

With the compat module stuff gets ugly real fast. QT6.0.2 is out, soc hecking against that seems reasonable.

iamantony commented 3 years ago

@cristeab thanks or starting an initiative of adding Qt6 support! Closing this PR in favor of PR#67.