Closed xaviershay closed 5 years ago
You can fix the missing categories by changing lines 11/12 of build/data_emoji_names_v11.txt to:
1F9B8{SKIN}-200D-{MALE/FEMALE};{GENDER}_superhero
1F9B9{SKIN}-200D-{MALE/FEMALE};{GENDER}_supervillain
This PR is looking really good - thank you for all the work you've put into it.
In the changes to build/download_spec_files.sh
, please use explicit versions - otherwise the build will immediately break when v12 comes out. Since each new version of Emoji/Uniccode requires a bunch of work to support, this should ne an explicit change.
I can't tell from the GitHub view, but i'll need to rebuild the sheets after merging the PR, ahead of cutting a new release. Rebuilding the JSON sets new grid positions for the emoji, so all sheets needs to be rebuilt, regardless of whether they have updated images. As new images get added for the non-apple sets, they'll need to get rebuilt again. This takes a long time, so maybe i'll spin up some giant EC2 instances to help chew through them.
Thank you! I didn't rebuild the sheets. I'm not using that feature so not really familiar with what it is/how it works...
This builds on https://github.com/iamcal/emoji-data/pull/146 and makes the following contributions:
emoji-test.txt
, and b) error more loudly if this is detected in the future.