search

iamcal / emoji-data

Easy to parse data and spritesheets for emoji
MIT License
2.56k stars 301 forks source link

skin_variations missing for new kiss/heart emoji combinations #195

Closed jwheare closed 3 years ago

jwheare commented 3 years ago

Post 13.1

COUPLE WITH HEART has skin_variations set in the json but e.g. COUPLE WITH HEART: WOMAN, MAN doesn't, nor does any other gendered version. As a result, only the non gender specific version has skin tones.

This also effects KISS

jwheare commented 3 years ago

Adding these to build/data_emoji_names_v13_1.txt and rebuilding should fix it:

{MAN/WOMAN}{SKIN!}-200d-2764-fe0f-200d-1f48b-200d-{MAN/WOMAN}{SKIN2};{M/W}-kiss-{M/W}
1F469{SKIN!}-200d-2764-fe0f-200d-1f48b-200d-1F468{SKIN2};woman-kiss-man
{MAN/WOMAN}{SKIN!}-200d-2764-fe0f-200d-{MAN/WOMAN}{SKIN2};{M/W}-heart-{M/W}
1F469{SKIN!}-200d-2764-fe0f-200d-1F468{SKIN2};woman-heart-man

I don't have the latest apple font to hand to test this fully with the images, but it fixes the json at least.

iamcal commented 3 years ago

good catch - there's something missing in the map builder because it should be flagging these as missing, so i'll patch that first. i suspect it's only checking base emoji and not skin-tone variations

iamcal commented 3 years ago

yeah - after commit 0813c5b58 i can see we're missing 190 emoji. going to need to re-extract images and rebuild everything, which takes a few hours

your patch to names takes care of 120 of them, but it needs a little more. great catch!

iamcal commented 3 years ago

I have uncovered so many bugs 😂

iamcal commented 3 years ago

there are now 190 new variations added to the data file on trunk. i need to do a full rebuild and re-optimize of the sheets

iamcal commented 3 years ago

Fixed in 7.0.1