Gender neutral couplekiss and couple_with_heart shouldn't be obsoleted by gendered version

iamcal / emoji-data

Easy to parse data and spritesheets for emoji

MIT License

2.57k stars 304 forks source link

Gender neutral couplekiss and couple_with_heart shouldn't be obsoleted by gendered version #197

Closed jwheare closed 3 years ago

jwheare commented 3 years ago

Pretty sure this doesn't affect the images at all so they shouldn't need to be regenerated. This just fixes the json for js-emoji et al.

iamcal commented 3 years ago

thank you. since you're so quick to adopt (and find bugs like this!), i need to find some mechanism to have you verify future versions before i publish them. are you installing via NPM, or using git?

jwheare commented 3 years ago

I just use git and a fork of js-emoji with a custom template and the latest emoji-data symlinked in.

jwheare commented 3 years ago

I'd be happy to be a github reviewer of new releases.

iamcal commented 3 years ago

thanks! i'll leave this change on trunk for a few days before cutting 7.0.2

i really need to update js-emoji to support multiple skin tones. it got blocked on an internal discussion about the preferred :colon-syntax: pattern, so is still on Unicode 10/Emoji 5.