search

iamcal / emoji-data

Easy to parse data and spritesheets for emoji
MIT License
2.55k stars 301 forks source link

Some emoji has wrong short code #210

Closed lyrixx closed 1 year ago

lyrixx commented 2 years ago

Hello,

A bit a context:

I'm working on https://github.com/symfony/symfony/pull/46755 ; And I'm planning to add support for translating emoji in short code too.

AFAIU short codes are not standardized and each platform has their own.

It looks like this repository contains the ones slack supports. Maybe I'm wrong, if you can confirm, it would be awesome. Like that I could re-use your work in Symfony!

So I was playing a bit with https://github.com/iamcal/emoji-data/blob/master/emoji.json and I noticed something strange.

The issue

Some short codes does not work in slack

The message I used:

Hello :wave:

`:women-with-bunny-ears-partying:` => :women-with-bunny-ears-partying:
`:woman-with-bunny-ears-partying:` => :woman-with-bunny-ears-partying:

`:men-with-bunny-ears-partying:` => :men-with-bunny-ears-partying:
`:man-with-bunny-ears-partying:` => :man-with-bunny-ears-partying:

The rendering:

image

lyrixx commented 2 years ago

ping @iamcal in case you missed it

stof commented 1 year ago

Based on the data sources, I guess the short names in that repo are actually the ones defined in Unicode.

iamcal commented 1 year ago

The short names in this repo are a mix of the original short names from Campfire, GitHub and Slack, official Unicode codepoint/sequence names, and invented names based on common suffixes. Slack uses a version of this data, but not usually the latest version, so there will be differences.