iamcal / emoji-data

Easy to parse data and spritesheets for emoji
MIT License
2.55k stars 301 forks source link

[v15.0.0 regression] Google set incorrectly displays ๐Ÿด๓ ง๓ ข๓ ณ๓ ฃ๓ ด๓ ฟ Scotland flag as ๐Ÿ‡ธ๐Ÿ‡จ Seychelles flag #231

Closed andersk closed 7 months ago

andersk commented 11 months ago

As of commit d5c6684a5573c26432f4bbd5a84645c7b477ef65 (#223) in v15.0.0, the Google set incorrectly displays ๐Ÿด๓ ง๓ ข๓ ณ๓ ฃ๓ ด๓ ฟ Scotland flag (1f3f4-e0067-e0062-e0073-e0063-e0074-e007f) as if it were ๐Ÿ‡ธ๐Ÿ‡จ Seychelles flag:

โœ”๏ธ v14.0.0, img-google-64: โœ”๏ธ v14.0.0, img-google-136 โŒ v15.0.0, img-google-64: โŒ v15.0.0, img-google-136:

All sets other than Google are unaffected:

โœ”๏ธ v15.0.0, img-apple-160: โœ”๏ธ v15.0.0, img-apple-64: โœ”๏ธ v15.0.0, img-facebook-64: โœ”๏ธ v15.0.0, img-facebook-96: โœ”๏ธ v15.0.0, img-twitter-64: โœ”๏ธ v15.0.0, img-twitter-72:

The upstream image in Noto Emoji is unaffected:

The related ๐Ÿด๓ ง๓ ข๓ ฅ๓ ฎ๓ ง๓ ฟ England flag (1f3f4-e0067-e0062-e0065-e006e-e0067-e007f) and ๐Ÿด๓ ง๓ ข๓ ท๓ ฌ๓ ณ๓ ฟ Wales flag (1f3f4-e0067-e0062-e0077-e006c-e0073-e007f) are unaffected:

โœ”๏ธ v15.0.0, img-google-64: โœ”๏ธ v15.0.0, img-google-136: โœ”๏ธ v15.0.0, img-google-64: โœ”๏ธ v15.0.0, img-google-136:

EtienneLem commented 8 months ago

black_bird is missing for the Google images and it breaks all the emojis listed after it. According to the JSON, it should be at [11, 25] on the sheet.

Data

{
  "name": "BLACK BIRD",
  "unified": "1F426-200D-2B1B",
  "non_qualified": null,
  "docomo": null,
  "au": null,
  "softbank": null,
  "google": null,
  "image": "1f426-200d-2b1b.png",
  "sheet_x": 11,
  "sheet_y": 25,
  "short_name": "black_bird",
  "short_names": [
      "black_bird"
  ],
  "text": null,
  "texts": null,
  "category": "Animals & Nature",
  "subcategory": "animal-bird",
  "sort_order": 620,
  "added_in": "15.0",
  "has_img_apple": true,
  "has_img_google": true,
  "has_img_twitter": false,
  "has_img_facebook": false
},

But if we compare the Apple vs. Google sheets, we can see the black bird is missing on Google:

Apple

apple

https://cdn.jsdelivr.net/npm/emoji-datasource-apple@15.0.0/img/apple/sheets-256/64.png

Google

google

https://cdn.jsdelivr.net/npm/emoji-datasource-google@15.0.0/img/google/sheets-256/64.png

EtienneLem commented 8 months ago

Ah wait, sorry, it was fixed in v15.0.1; make sure you use the latest version.

andersk commented 8 months ago

I am using the latest versionโ€”I just reported it for the version in which it regressed. There have been no commits to these images since v15.0.0; my issue was not fixed in v15.0.1.

โŒ v15.0.1, img-google-64: โŒ v15.0.1, img-google-136:

iamcal commented 7 months ago

Thanks for reporting this (and in so much detail). This broken when Google changed how they laid out their repo and specifically the calculated/composed flags. I'm landing a fix now that addresses this.

andersk commented 7 months ago

Youโ€™re welcome! If you donโ€™t mind my drawing some attention to a separate issue, can you please also take a look at this very easy PR?

iamcal commented 7 months ago

This is now fixed on master. I'll wait a few days before cutting a new release, while other bug reports come in.

jwheare commented 7 months ago

Just to let you know that I've now updated IRCCloud emoji to 15.1 and all looks fine. Thanks for your efforts.