search

iamcal / js-emoji

A JS Emoji conversion library
MIT License
1.42k stars 232 forks source link

Multiple encodings for the same emoji #8

Closed jwheare closed 10 years ago

jwheare commented 10 years ago

Hello, an example, I have a feeling there are plenty of others:

I notice the current shipped emoji.js has a mapping for '0023' to :hash: but if I rebuild all the data afresh from all the submodules I end up with a mapping for '0023-fe0f-20e3'. The three byte version seems to be what OS X sends, while iOS7 sends a 2-byte version ''0023-20e3'.

Older versions of iOS send yet further versions, e.g. this page suggests iOS2-4 used 'e210', and I see that's covered by the softbank lookup in emoji.js (gets lost when I rebuild), though I have much less interest in supporting pre-iOS5 than I do current OS X 10.9.2 and iOS7

The images from the latest gemoji have both 2 and 3-byte versions (0023-20e3.png is a symlink to 0023-fe0f-20e3.png, but there's no 0023.png) and I'd like to support both versions, but not sure how I can get a mapping that includes them both in emoji.js.

A separate example that breaks in a different way is :relaxed:

iOS 5-6: 263a iOS 7 and OSX 10.9.2: 263a-fe0f emoji.js mapping (current and rebuilt): 263a, results in :relaxed:[] gemoji: 263a.png and 263a-fe0f.png

Thanks!

jwheare commented 10 years ago

This is fixed by https://github.com/iamcal/emoji-data/pull/3