search

iamcal / oembed

The oEmbed Spec
http://oembed.com
MIT License
1.32k stars 651 forks source link

Fix missing scheme for Screencast.com #519

Closed orawalters closed 3 years ago

orawalters commented 3 years ago

I'm not sure if this is an error in the library I'm using, or in the entry here but I suspect the lack of scheme is what's causing Screencast URLs to not pass the whitelist. This commit fixes that.

iamcal commented 3 years ago

This PR is failing CI with the following error message:

Endpoint without URL found in provider file providers/screencast.com.yml

iamcal commented 3 years ago

~looks like it's still failing. you can run the tests locally via php test.php to check if it's fixed~

i see you've pushed a further change :+1:

iamcal commented 3 years ago

merged and site updated, thanks. changes will be reflected when caches expire in ~1hr