iamcal / oembed

The oEmbed Spec
http://oembed.com
MIT License
1.32k stars 651 forks source link

Added support for kooapp.com #590

Closed adyontech closed 2 years ago

adyontech commented 2 years ago

Added support for kooapp.com

iamcal commented 2 years ago

Your PR has been merged and site has been updated, thanks.

Using the central registry via HTTP is highly discouraged - you should instead use the discovery mechanism to allows services to consume OEmbed resources: https://oembed.com/#section4

If you need to consume the registry data, please use the NPM package as detailed in the README.

adyontech commented 2 years ago

hey @iamcal, I tried section 4 approach but not sure about what wrong I am doing here. So, this is how my link looks like in response header:

Link: <https://embed-stage.kooapp.com/services/oembed?url=http://embed-parent.kooapp.com/koo/BKShivani/39812e7b-4c8c-43ba-a7e5-3f55a0ebb19b/>; rel="alternate"; type="application/json+oembed"; title="Koo app id"

but one of the wordpress API keeps sending 404 API:

GET https://public-api.wordpress.com/oembed/1.0/sites/199091443/proxy?_envelope=1&url=https://embed-parent.kooapp.com/koo/BKShivani/39812e7b-4c8c-43ba-a7e5-3f55a0ebb19b&environment-id=production&_gutenberg_nonce=6e0d7f2d0c&_locale=user

could you pls help me understand what wrong I am doing here?

iamcal commented 2 years ago

it looks to be working correctly based on the spec. i don't know why wordpress is having trouble with it, sorry