iamcal / oembed

The oEmbed Spec
http://oembed.com
MIT License
1.32k stars 651 forks source link

Trinity Audio: update schemas and endpoint #690

Closed industral closed 1 year ago

industral commented 1 year ago

BTW, I don't understand why Discovery doesn't work. I have test URL: https://trinitymedia.ai/player/oembed.php?url=https%3A%2F%2Ftrinitymedia.ai%2Fplayer%2Ftrinity%2F%3FpageURL%3Dhttps%3A%2F%2Fexample.com%2Fpage-1%26unitId%3D12345

which returns header

link: <https://trinitymedia.ai/services/oembed?url=https%3A%2F%2Ftrinitymedia.ai%2Fplayer%2Ftrinity%2F%3FpageURL%3Dhttps%3A%2F%2Fexample.com%2Fpage-1%26unitId%3D12345>; rel='alternate'; type='application/json+oembed'

but here https://oembed.link/https://trinitymedia.ai/player/oembed.php?url=https%3A%2F%2Ftrinitymedia.ai%2Fplayer%2Ftrinity%2F%3FpageURL%3Dhttps%3A%2F%2Fexample.com%2Fpage-1%26unitId%3D12345

you can see that it triggers old endpoint, due to message I see:

An error has occured:

Oembed API Json could not be loaded: https://trinitymedia.ai/player/trinity-oembed?url=https%3A%2F%2Ftrinitymedia.ai%2Fplayer%2Foembed.php%3Furl%3Dhttps%253A%252F%252Ftrinitymedia.ai%252Fplayer%252Ftrinity%252F%253FpageURL%253Dhttps%253A%252F%252Fexample.com%252Fpage-1%2526unitId%253D12345&format=json&maxwidth=640&maxheight=480

https://trinitymedia.ai/player/trinity-oembed - it's old endpoint

iamcal commented 1 year ago

merged and site updated, thanks. changes will be reflected when caches expire in ~1hr

i'm not sure why oembed.link is not picking up your discovery header - that would be a question for whoever runs that service, sorry

industral commented 1 year ago

got it. thank you!