search

iamcco / coc-angular

Angular Language Service coc extension for (neo)vim
146 stars 17 forks source link

fix: compatibility with angular 13 #43

Closed cedricduffournet closed 2 years ago

cedricduffournet commented 2 years ago

Package does not work with angular v13 (many errors displayed in html file).

Updating language-server to 13.0.0 and typescript to 4.4.4 fix the issue.

I deleted all references to experimental-ivy as it does not exist anymore

iamcco commented 2 years ago

Need to track all patch in the origin repo instead of just upgrade angular version. Also it seems it does not work on my angular 11 project.

PS. do not apply code format on the code, it will make it more harder to track patch from upstream change.

cedricduffournet commented 2 years ago

ha yes, sorry about the code format, I did not check correcly. I thought you could make different tag depending on angular version. I close the PR and I let you manage the update ?

cedricduffournet commented 2 years ago

Actually on vscode there is a new option angular.view-engine depending on this option, they load language-service v12.2.12 or v13 to make it compatible with old angular version

cedricduffournet commented 2 years ago

I fix code format

iamcco commented 2 years ago

I have update all change from upstream https://github.com/iamcco/coc-angular/pull/44

cedricduffournet commented 2 years ago

thank you !